ci: adopt release-please for versioning and releases#30
Merged
Conversation
Replace the manual "bump version, commit, push tag" flow with release-please. On push to main it maintains a release PR that bumps every version location in lockstep and writes CHANGELOG.md from conventional commits; merging it tags and creates the GitHub Release. - release-please-config.json / .release-please-manifest.json: single rust-type component. Bumps the workspace version + Cargo.lock, the two rompatch-core path-dep pins (x-release-please-version annotations keep them in step so the exact-version pin doesn't break the build), and ui/package.json. - release-please.yml: runs release-please; on release_created it calls release-build.yml via workflow_call. release-please tags with the default GITHUB_TOKEN, which can't trigger tag-push workflows, so the build is invoked directly rather than via on:push:tags. - release-build.yml: the signed universal .dmg build, notarization, updater latest.json, attestation, and release upload - lifted out of ci.yml and driven by a `tag` input instead of github.ref. softprops drops generate_release_notes so release-please owns the release body; it only attaches artifacts. workflow_dispatch is kept as a manual escape hatch. - ci.yml: drop the tag trigger and the tag-gated release steps; the gui job stays as a PR/main check. Co-Authored-By: Claude
GregTheGreek
marked this pull request as ready for review
July 6, 2026 11:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the manual "bump version, commit
chore(release), push tag" flow with release-please. On push tomainit maintains a release PR that bumps every version location in lockstep and writesCHANGELOG.mdfrom conventional commits; merging it tagsvX.Y.Zand creates the GitHub Release. The existing tag-vs-Cargo.toml guardrail still holds since both move together.release-please-config.json+.release-please-manifest.json: single rust-type component. Bumps workspace version +Cargo.lock, the tworompatch-corepath-dep pins (annotations keep the exact-version pin from breaking the build), andui/package.json.release-please.yml: runs release-please; onrelease_createdcallsrelease-build.ymlviaworkflow_call(release-please tags withGITHUB_TOKEN, which can't triggeron:push:tags, so we invoke the build directly).release-build.yml: the signed.dmgbuild / notarize /latest.json/ attest / upload, lifted out ofci.yml, driven by ataginput. Dropsgenerate_release_notesso release-please owns the body.workflow_dispatchkept as a manual escape hatch.ci.yml: tag trigger + release steps removed;guijob stays a PR/main check.Manual prerequisites (repo settings)
Test plan
mainCargo.toml,Cargo.lock, bothrompatch-corepins, andui/package.jsonall bump to the same versionvX.Y.Z, andrelease-build.ymlattaches the.dmg+.app.tar.gz+.sig+latest.jsonto the release