fix(ci): use generic updater for Cargo.toml extra-files#31
Merged
Conversation
release-please picked its CargoToml updater for the two Cargo.toml extra-files (by filename) and crashed with "value at path package.version is not tagged" - those member crates use version.workspace = true, which isn't a literal it can edit. Pin them to the generic updater so it only touches the x-release-please-version annotated dependency-pin lines. Co-Authored-By: Claude
GregTheGreek
marked this pull request as ready for review
July 6, 2026 13:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first release-please run failed:
value at path package.version is not tagged. release-please auto-selected its CargoToml updater for the twoCargo.tomlextra-files(chosen by filename), which tries to editpackage.version- but those member crates useversion.workspace = true, not a literal. Pin those two entries totype: genericso release-please only rewrites thex-release-please-version-annotatedrompatch-corepin lines.Test plan
Cargo.toml,Cargo.lock, bothrompatch-corepins, andui/package.jsonto the same version