fix(ci): declare literal crate versions so release-please can bump them#33
Merged
Merged
Conversation
The rust release strategy rewrites package.version in every workspace
member and fails on workspace-inherited versions ("value at path
package.version is not tagged"), which is why no release PR was ever
created. Move the version from [workspace.package] into each crate and
drop the generic Cargo.toml extra-files; the rust strategy updates
member versions, the rompatch-core dependency requirements, and
Cargo.lock natively.
Co-Authored-By: Claude
GregTheGreek
marked this pull request as ready for review
July 6, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-please has failed on every main push with
value at path package.version is not tagged: the rust strategy rewritespackage.versionin each workspace member and cannot handleversion.workspace = true. This moves the version from[workspace.package]into each crate (all still 0.3.1) and drops the now-redundant generic Cargo.toml extra-files - the rust strategy bumps member versions, therompatch-coredep requirements, andCargo.locknatively.Test plan
cargo build --workspace --lockedpasses with no lockfile drift