fix(ci): switch release-please to the simple strategy#34
Merged
Conversation
The rust strategy requires the package root Cargo.toml to contain a
[package] section and fails on our virtual workspace manifest ("is not
a package manifest"). Use release-type simple with x-release-please-
version annotations on the three crate versions and the rompatch-core
dependency requirements, keeping a single release PR, tag, and
changelog. Since the simple strategy cannot update Cargo.lock, the
workflow now runs cargo update --workspace on the release branch and
commits the result.
Co-Authored-By: Claude
GregTheGreek
marked this pull request as ready for review
July 6, 2026 14:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third release-please failure mode: the rust strategy insists on bumping
package.versionin the package root's Cargo.toml, and ours is a virtual workspace manifest (is not a package manifest (might be a cargo workspace)). The rust type cannot work with this layout short of per-crate packages + cargo-workspace plugin, which would mean component tags and three changelogs.Instead:
release-type: simplewith# x-release-please-versionannotations on the three crateversionlines and the tworompatch-coredependency requirements, plus the existing package.json jsonpath entry. One release PR, onevX.Y.Ztag, one root CHANGELOG covering all commits; workflow outputs unchanged. The simple strategy cannot update Cargo.lock, so the workflow now runscargo update --workspaceon the release branch and commits the result whenever the PR is (re)created.Note: the simple strategy also maintains a
version.txtat the repo root; it will appear in the first release PR.Test plan
cargo metadata+cargo build --lockedpass with the annotations