feat: distribute a notarized .dmg instead of a .zip#16
Merged
Conversation
5 tasks
GregTheGreek
marked this pull request as ready for review
July 10, 2026 16:59
Package releases as a compressed dmg (app + drag-to-Applications shortcut)
rather than a zip. Notarize twice so the downloaded dmg and the app inside
are both stapled: staple the app, rebuild the dmg around it, then notarize
and staple the dmg.
Also wipe stale build/Trapps-*.{zip,dmg} at the start of `make release` so a
leftover artifact from an earlier version cannot be picked up. Pin the docs'
`gh release upload` to the exact versioned file instead of a glob, which is
what previously attached two builds to one release.
Co-Authored-By: Claude
Submitting the dmg already notarizes the enclosed app, so drop the separate app submission/staple. The app stays notarized (online-verified); skipping the app staple only forgoes offline first-launch, which is moot for a brew-installed tool that was downloaded over the network. Co-Authored-By: Claude
GregTheGreek
force-pushed
the
feat/release-dmg
branch
from
July 10, 2026 17:04
914ddac to
b870d37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release a compressed, notarized
.dmg(app + drag-to-Applications shortcut) instead of a zip, and stop stale artifacts from leaking into a release.make releasenow wipesbuild/Trapps-*.{zip,dmg}first, so a leftover from an earlier version can't be picked up (root cause of two builds landing on one release).make notarizesubmits the dmg in a single round-trip and staples it. Submitting the dmg notarizes the enclosed app too; the app stays notarized (online-verified), we just skip the app staple - offline first launch is moot for a brew-installed, network-downloaded tool.make cask, and docs updated to the dmg. Docs'gh release uploadnow pins the exact versioned file instead of a glob.Test plan
make -n release/notarize/caskproduce the expected commandsmake release && make notarizeon a real tag, thenbrew install --caskfrom the tap