fix(forge-ui): correct branch protection status checks + bypass actors - #29
Merged
Conversation
Contributor
AI ReviewSecurity
Best Practices
Correctness
Suggestions
Overall, the diff is well-structured and adheres to Terraform best practices in most areas, but the above points should be addressed to improve security, maintainability, and correctness. Powered by GitHub Models ( |
Contributor
✅ OpenTofu Plan ·
|
GregoireF
force-pushed
the
fix/forge-ui-branch-protection
branch
from
July 2, 2026 21:40
7130867 to
503c34e
Compare
GregoireF
force-pushed
the
fix/forge-ui-branch-protection
branch
from
July 2, 2026 21:42
503c34e to
c633aba
Compare
- Fix required status check names on main (were placeholder values): now uses exact job names from CI, E2E, dependency-review workflows - Add bypass_actors for github-actions[bot] so changesets can push version-bump commits to main - Extend module with optional additional_rulesets for non-default branch protection (generic for_each resource) - Configure protect-develop ruleset on forge-ui: CI only, no E2E, github-actions[bot] bypass for Renovate direct automerge Signed-off-by: Gregoire <mohinette@hotmail.fr> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
required_status_checks: replace placeholder"CI"(never matched any check) with real GitHub Actions job namesbypass_actorsforgithub-actions[bot](actor_id=15368) — needed for changesets to push version-bump commits tomain"Dependency review"as required checkReal check names (from forge-ui
.github/workflows/)Typecheck · Lint · Test · Buildci.ymljob nameCommitlintcommitlint.ymljob nameE2E (chromium)e2e.ymlmatrixE2E (firefox)e2e.ymlmatrixE2E (webkit)e2e.ymlmatrixDependency reviewTest plan
tofu planshows only the forge-ui ruleset being updated (no destroy)tofu apply, verify correct checks appear in GitHub repo settingsgithub-actions[bot]bypass works for changesets release flow🤖 Generated with Claude Code