fix(github): add missing depends_on between labels and repository - #32
Merged
Conversation
Fresh repo creation raced label creation against the GitHub API's propagation delay -- 9 of 17 labels for dd-toolkit failed with '404 Not Found' because each.value.repository is a plain string, giving Terraform no dependency edge to the repository module. Existing repos never hit this since their labels already exist (no-op diff). Signed-off-by: Gregoire <mohinette@hotmail.fr>
Contributor
AI ReviewSecurity
Best practices
Correctness
Suggestions
The diff looks clean and addresses a real-world issue effectively. Good work! Powered by GitHub Models ( |
Contributor
✅ OpenTofu Plan ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dd-toolkitrepo addition (feat(github): add dd-toolkit repository #31): 9 of its 17 standard labels failed withPOST .../labels: 404 Not Found.github_issue_label.standardreferenceseach.value.repository, a plain string fromlocal.repo_labels— not an attribute ofmodule.repository, so Terraform has no graph edge forcing repo creation to finish first. Existing repos never surfaced this (labels already exist -> no-op), only a brand-new repo racing its own creation against label creation in the same apply.depends_on = [module.repository]on the label resource.Test plan