Skip to content

fix(github): require dd-toolkit's real CI check name #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GregoireF merged 1 commit into from
Jul 16, 2026
Merged

fix(github): require dd-toolkit's real CI check name #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions terraform/github/locals.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,12 +298,11 @@ locals {
branch_protection = {
enabled = true
# "Commitlint" matches the check name used successfully across every
# other repo in this file. This repo's own ci.yml ("test-and-build")
# check isn't listed yet — add it once the real check name is
# confirmed from an actual PR run (see forge-ui above: a guessed
# placeholder ("CI") never matched any check and had to be corrected
# after the fact — better to add it once verified than guess wrong).
required_status_checks = ["Commitlint"]
# other repo in this file. "test-and-build" confirmed from a real
# run of dd-toolkit's own ci.yml (job id, not the workflow's display
# name "CI" -- see forge-ui above for why a guessed display name
# doesn't match).
required_status_checks = ["Commitlint", "test-and-build"]
require_pr_reviews = false
}

Expand Down
Loading