Skip to content

removed rtc time #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielkucera wants to merge 1 commit into
base: master
Choose a base branch
from
Open

removed rtc time #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,6 @@ api:

ota:

time:
- platform: sntp
id: sntp_time

climate:
- platform: cometblue
pin: 0000
Expand Down
4 changes: 0 additions & 4 deletions cometblue/climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

ESP_PLATFORMS = [ESP_PLATFORM_ESP32]
CONFLICTS_WITH = ['esp32_ble_tracker']
DEPENDENCIES = ['time']
AUTO_LOAD = ['sensor', 'esp32_ble_clients']

CONF_TEMPERATURE_OFFSET = 'temperature_offset'
Expand All @@ -19,7 +18,6 @@

CONFIG_SCHEMA = cv.All(climate.CLIMATE_SCHEMA.extend({
cv.GenerateID(): cv.declare_id(CometBlueClimate),
cv.GenerateID(CONF_TIME_ID): cv.use_id(time.RealTimeClock),
cv.Required(CONF_MAC_ADDRESS): cv.mac_address,
cv.Optional(CONF_PIN, default=-1): cv.int_range(min_included=0, max_included=9999999),
cv.Optional(CONF_TEMPERATURE_OFFSET, default=0): cv.float_range(min_included=-3, max_included=+3),
Expand All @@ -38,5 +36,3 @@ def to_code(config):
cg.add(var.set_temperature_offset(config[CONF_TEMPERATURE_OFFSET]))
cg.add(var.set_window_open_config(config[CONF_WINDOW_OPEN_SENSITIVITY],config[CONF_WINDOW_OPEN_MINUTES] ))

time_ = yield cg.get_variable(config[CONF_TIME_ID])
cg.add(var.set_time(time_))
4 changes: 0 additions & 4 deletions cometblue/cometblue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#include "esphome/core/component.h"
#include "esphome/components/sensor/sensor.h"
#include "esphome/components/climate/climate.h"
#include "esphome/components/time/real_time_clock.h"


#ifdef ARDUINO_ARCH_ESP32
Expand Down Expand Up @@ -42,7 +41,6 @@ class CometBlueClimate :
void set_address(uint64_t new_address) { address = new_address; }
void set_pin(uint32_t new_pin) { pin = new_pin; }
void set_temperature_offset(float offset) { temperature_offset = offset; }
void set_time(esphome::time::RealTimeClock *clock) { time_clock = clock; }
void set_window_open_config(int8_t sensitivity, int8_t minutes) { window_open_sensitivity = sensitivity; window_open_minutes = minutes; }

public:
Expand All @@ -60,7 +58,6 @@ class CometBlueClimate :
void control_retry(esphome::climate::ClimateCall call, int retry);

bool send_pincode();
bool get_time();
bool get_temperature();
bool get_flags();

Expand All @@ -80,7 +77,6 @@ class CometBlueClimate :
float temperature_offset;
uint8_t window_open_minutes;
uint8_t window_open_sensitivity;
esphome::time::RealTimeClock *time_clock{nullptr};
std::unique_ptr<ESP32BLEClient> ble_client;
};

Expand Down
5 changes: 0 additions & 5 deletions cometblue/cometblue_cmd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,6 @@ bool CometBlueClimate::send_pincode() {
return true;
}

bool CometBlueClimate::get_time() {
// Not yet implemented
return false;
}

bool CometBlueClimate::get_flags() {
if (read_value(PROP_FLAGS_CHARACTERISTIC_UUID)) {
uint8_t status = ble_client->readresult_value[0];
Expand Down