Fix window width on multi-monitor setups with different resolutions#2323
Open
nox-404 wants to merge 1 commit intoGuake:masterfrom
Open
Fix window width on multi-monitor setups with different resolutions#2323nox-404 wants to merge 1 commit intoGuake:masterfrom
nox-404 wants to merge 1 commit intoGuake:masterfrom
Conversation
Author
|
I'm no python expert so feel free to tell me if something isn't right or if it might not work on other environment. I did get help from |
nox-404
force-pushed
the
nox-404/fix-multimonitor-width
branch
from
04da841 to
d8cd6af
Compare
nox-404
changed the title
nox-404
force-pushed
the
nox-404/fix-multimonitor-width
branch
2 times, most recently
from
1e5d6d6 to
9ad2762
Compare
nox-404
force-pushed
the
nox-404/fix-multimonitor-width
branch
from
9ad2762 to
7f13d73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On multi-monitor setups with different widths, Guake would sometimes open or resize to the wrong width.
Tab spawn issue
When creating a new Tab, there would be a high chance of the window width not matching the current monitor
Hide/Show issue
When hiding and showing the window, it would sometimes shows with a width not matching the current monitor
Test
I manually tested this issue on a multi-monitor setup (1920x1200 and 2560x1440).
1.11(GDK_BACKEND=wayland)3.24.520.84.0sem-ver: bugfix