feat: lighthouse integration, pnpm workspace setup, and CI optimization by Tarektouati · Pull Request #243 · Gudsfile/tracksy

Tarektouati · 2026-01-21T20:07:58Z

1️⃣ First

I have read the CONTRIBUTION.md.

🔇 Problem

Missing Core Web Vitals measurements during user journey in E2E
Need of shared pnpm-lock.yml between app and e2e (node.js apps) for consolidation
CI/CD optimization around moon setup
Health check of our application.

🎹 Proposal

Lighthouse & E2E:

Usage of lighthouse integration in Playwright tests.
Added "Black Box" testing black-box-test.yml to run e2e tests against arbitrary URLs.
Added helper utilities (computeJourneyScore, runLighthouseStep) with full unit test coverage using vitest.

Workspace & Architecture:

pnpm Workspace: Initialized root pnpm-workspace.yaml and package.json to manage app and e2e packages.
Shared Formatting: Created base.prettier.mjs for consistent code style across the monorepo and applied it to the e2e package.
Lockfile Consolidation: Migrated to a centralized pnpm-lock.yaml.

CI/CD:

Workflow Optimization: Updated all GitHub Actions workflows to leverage moonsetup with auto-install and caching for faster builds.

Testing Strategy:

Unit Tests: Run moon run e2e:test to verify new Lighthouse helpers.
E2E Tests: Run moon run e2e:run to verify the user journey and performance scoring.
CI Verification: Validated via the new black-box-test GH workflow and existing build/deploy pipelines.

🎶 Comments

This PR address multiple problems, it could be split in multiple stacked PRs

github-actions · 2026-01-21T20:09:08Z

PR Preview Action v1.8.1
🚀 View preview at https://Gudsfile.github.io/tracksy/pr-preview/pr-243/
Built to branch `gh-pages` at 2026-02-07 16:59 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Tarektouati · 2026-02-03T21:13:22Z

+            STEP_WEIGHTS
+        )
+
+        console.log({ globalScore })


next step is to publish this score in PRs

Tarektouati · 2026-02-03T21:18:07Z

  defaultBranch: "main"
+  syncHooks: true
  hooks:
+    # HACK: unset GIT_INDEX_FILE is needed to prevent git from locking the index file during a commit before running the moon tasks. This forces moon to use the standard repository index, which prevents the conflict.


important: this why git-hooks weren't working since moon migration from husky

Tarektouati · 2026-02-03T21:19:52Z

+import lighthouse from 'lighthouse'
+
+// HACK: we rely on mock instead of spy as this is the only way to spy on the default export https://vitest.dev/guide/browser/#spying-on-module-exports
+vi.mock('lighthouse', { spy: true })


important: This ain't mock it's a more of spy for packages that have default export

https://vitest.dev/guide/browser/#spying-on-module-exports

Tarektouati · 2026-02-04T20:53:40Z

+const config = {
+  test: {
+    environment: "node",
+    setupFiles: "./vitest.setupFiles.ts",
+    include: ["**/*.test.?(c|m)[jt]s?(x)"],
+    exclude: ["**/node_modules/**", "**/tests/**"],
+    sequence: { shuffle: true },
+    passWithNoTests: false,
+    coverage: {
+      reporter: ["text"],
+      exclude: [...coverageConfigDefaults.exclude],
+    },
+    restoreMocks: true,
+  },
+};


Config could be common with app

Tarektouati · 2026-02-04T21:13:08Z

+on:
+  schedule:
+    - cron: "0 8 * * *"


remove cron, usless as we run e2e on new commits on main + PR

Gudsfile

LGTM 🚀 Many thanks!

bengeois

suggestion: should we rename commit to keep conventional commit ?

bengeois · 2026-02-08T21:18:49Z

+  syncHooks: true
  hooks:
+    # HACK: unset GIT_INDEX_FILE is needed to prevent git from locking the index file during a commit before running the moon tasks. This forces moon to use the standard repository index, which prevents the conflict.
    pre-commit:


question: I'm wondering why there are theses two commands here and also in .moon/hooks/pre-commit.sh ? Can we have it in one place ?

bengeois · 2026-02-08T21:20:36Z

@@ -0,0 +1,14 @@
+{
+  "name": "tracksy",
+  "version": "0.0.0",


Suggested change

"version": "0.0.0",

"version": "0.4.0",

Maybe ? 🎉

…mium.

https://pnpm.io/workspaces The core idea is to have shared node_modules between JS apps and avoid re-installing X times dependencies Also if any patch or overrides needed in case of CVE, it would easily apply for all

This workflow will be trigger with workflow_dispatch and cron (everyday at 8 AM)

setup-toolchain's auto-install runs pnpm outside of moon's task context, where moon's managed pnpm isn't in PATH yet. Disabling it lets moon inject pnpm into PATH properly when tasks run. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

auto-setup: true runs moon setup inside the action's Node.js process which does not update $GITHUB_PATH, so moon can't find its managed pnpm when tasks run. Running moon setup as an explicit shell step correctly exports the tool paths to the environment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

moon setup installs pnpm via proto to ~/.proto/tools/ and creates shims in ~/.proto/shims/, but this directory is never added to $GITHUB_PATH. Subsequent steps (including moon's own auto-install before tasks) can't resolve pnpm by name. Exporting the shims and bin dirs keeps pnpm coming from moon's toolchain without any external action. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

moon setup installs Node but does not create the pnpm shim at ~/.proto/shims/pnpm. Adding the shims dir to PATH is useless if the shim file never exists. proto install pnpm 9 explicitly downloads pnpm and writes the shim, which moon then finds when auto-installing project deps before tasks run. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

proto refuses to install pnpm if it cannot confirm node is installed. When moon setup skips toolchains due to cache hits, the proto store may have no record of node, causing proto install pnpm to fail with requirements_not_met. Installing node first satisfies the check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

proto's pnpm installer requires node to be declared in .prototools, not just present in the binary store. Without it, proto install pnpm fails with requirements_not_met even after proto install node. Adding .prototools with node=24/pnpm=9 and running proto use lets proto resolve the dependency chain and create the pnpm shim. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

In pnpm workspace mode, overrides in member package.json files are silently ignored — they must be in the root package.json. The yaml override (yaml@>=2.0.0 <2.8.3: >=2.8.3) was in app/package.json only, leaving yaml@2.7.1 vulnerable in the astrojs/check dep chain. Moves both overrides (lodash, yaml) to root package.json and removes the now-redundant pnpm.overrides block from app/package.json. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

The untracked .npmrc was lost, leaving no explicit config for autoInstallPeers. pnpm 9 in CI defaults to true while the lockfile recorded false, causing ERR_PNPM_LOCKFILE_CONFIG_MISMATCH on frozen installs. Commits .npmrc with auto-install-peers=true and regenerates the lockfile to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions Bot pushed a commit that referenced this pull request Jan 21, 2026

chore(): deploy Tracksy App Preview for PR #243

423133f

Tarektouati force-pushed the feat/add-core-web-vitals branch from 8524702 to ed3a649 Compare February 2, 2026 17:25

github-actions Bot pushed a commit that referenced this pull request Feb 2, 2026

chore(): deploy Tracksy App Preview for PR #243

301c646

Tarektouati force-pushed the feat/add-core-web-vitals branch from ed3a649 to cb9977b Compare February 3, 2026 15:59

github-advanced-security AI found potential problems Feb 3, 2026

View reviewed changes

Comment thread .github/workflows/black-box-test.yml Fixed

Tarektouati force-pushed the feat/add-core-web-vitals branch 2 times, most recently from 9e9cfe2 to eac49bc Compare February 3, 2026 18:48

github-actions Bot pushed a commit that referenced this pull request Feb 3, 2026

chore(): deploy Tracksy App Preview for PR #243

056eda1

Tarektouati force-pushed the feat/add-core-web-vitals branch from 7f41196 to cac80d1 Compare February 3, 2026 19:21

Tarektouati changed the title ~~feat: introduce Core Web Vitals in E2E~~ feat: lighthouse integration, pnpm workspace setup, and CI optimization Feb 3, 2026

Tarektouati force-pushed the feat/add-core-web-vitals branch from ed9388e to e20354d Compare February 3, 2026 20:18

Tarektouati marked this pull request as ready for review February 3, 2026 20:19

Tarektouati requested review from Gudsfile and bengeois as code owners February 3, 2026 20:19

Tarektouati force-pushed the feat/add-core-web-vitals branch 3 times, most recently from e793398 to 60ed862 Compare February 3, 2026 21:12

Tarektouati commented Feb 3, 2026

View reviewed changes

Tarektouati force-pushed the feat/add-core-web-vitals branch from 60ed862 to 6826ef3 Compare February 3, 2026 21:16

Tarektouati commented Feb 3, 2026

View reviewed changes

Tarektouati added enhancement New feature or request ci/cd Impacts continuous integration and continuous delivery [ app ] Concerns the front-end e2e Concerns the E2E tests performance Concerns performance (Front-end, synthetics, ...) labels Feb 4, 2026

Tarektouati commented Feb 4, 2026

View reviewed changes

Tarektouati force-pushed the feat/add-core-web-vitals branch from 6826ef3 to b114178 Compare February 7, 2026 16:58

Tarektouati mentioned this pull request Feb 7, 2026

vitest common config #259

Open

Gudsfile approved these changes Feb 7, 2026

View reviewed changes

Gudsfile previously approved these changes Feb 7, 2026

View reviewed changes

bengeois assigned Tarektouati Feb 8, 2026

bengeois previously approved these changes Feb 8, 2026

View reviewed changes

Tarektouati dismissed stale reviews from bengeois and Gudsfile via 96adc35 May 10, 2026 20:36

Tarektouati force-pushed the feat/add-core-web-vitals branch from b114178 to 96adc35 Compare May 10, 2026 20:36

Tarektouati added 12 commits May 11, 2026 14:51

chore: reformat E2E test file

fbdbf81

feat: introduce basic lighthouse test

466198f

rename E2E user journey

2136a86

setup vitest for E2E helpers

ba3c49f

create and use getTestPath util for E2E

a1859ec

implement Lighthouse performance audits for E2E user journeys on Chro…

430af04

…mium.

use pnpm-workspaces to create unique pnpm-lock.yml

8a67bc5

https://pnpm.io/workspaces The core idea is to have shared node_modules between JS apps and avoid re-installing X times dependencies Also if any patch or overrides needed in case of CVE, it would easily apply for all

update git-hooks with moon

90f2c21

create a shared prettier config between app and e2e

921b301

format all e2e files with prettier config

9f3949a

add black-box GH workflow

9010869

This workflow will be trigger with workflow_dispatch and cron (everyday at 8 AM)

remove moon extra step and use auto-setup + auto-install

b06fb39

Tarektouati force-pushed the feat/add-core-web-vitals branch from 96adc35 to b06fb39 Compare May 11, 2026 12:53

Tarektouati and others added 8 commits May 11, 2026 15:07

Tarektouati marked this pull request as draft May 21, 2026 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: lighthouse integration, pnpm workspace setup, and CI optimization - #243

feat: lighthouse integration, pnpm workspace setup, and CI optimization#243
Tarektouati wants to merge 20 commits into
mainfrom
feat/add-core-web-vitals

Tarektouati commented Jan 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 21, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-02-07 16:59 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

Uh oh!

Tarektouati Feb 3, 2026

Uh oh!

Tarektouati Feb 3, 2026

Uh oh!

Tarektouati Feb 3, 2026

Uh oh!

Tarektouati Feb 4, 2026

Uh oh!

Tarektouati Feb 4, 2026

Uh oh!

Gudsfile left a comment

Uh oh!

bengeois left a comment

Uh oh!

bengeois Feb 8, 2026

Uh oh!

bengeois Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Tarektouati commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1️⃣ First

🔇 Problem

🎹 Proposal

Lighthouse & E2E:

Workspace & Architecture:

CI/CD:

Testing Strategy:

🎶 Comments

Uh oh!

github-actions Bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2026-02-07 16:59 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

Uh oh!

Tarektouati Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Tarektouati Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Tarektouati Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Tarektouati Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Tarektouati Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Gudsfile left a comment

Choose a reason for hiding this comment

Uh oh!

bengeois left a comment

Choose a reason for hiding this comment

Uh oh!

bengeois Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

bengeois Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Tarektouati commented Jan 21, 2026 •

edited

Loading

github-actions Bot commented Jan 21, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-02-07 16:59 UTC.
Preview will be ready when the GitHub Pages deployment is complete.