Open
Conversation
- Added a dedicated buzzer configuration file (`buzzer-support-e5m.cfg`) for the E5M model, containing specific G-code commands for beep functionality. - Updated `scripts/paths.sh` to include a path variable for the new E5M-specific buzzer configuration. - Modified `scripts/buzzer_support.sh` so that the `install_buzzer_support` function now links the E5M-specific configuration when the selected model is E5M, and the default configuration for all other models. - Verified that the `remove_buzzer_support` function correctly handles removal for both default and E5M-specific configurations.
Adds initial support for the Ender-5 S1 (E5M) printer model (F004).\n\nKey changes include:\n- New E5M specific menu files and main menu integration.\n- Updated paths.sh for E5M specific configurations.\n- Customized screws_tilt_adjust.cfg for E5M screw order.\n- Removed "Custom Boot Display" option from customize_menu_E5M.sh.\n- E5M Buzzer Support: Links E5M-specific buzzer config containing macros.\n- E5M Fans Control Macros (Option 9): Directly modifies gcode_macro.cfg with E5M specific M106/M107 definitions, including backup/restore. Non-E5M printers retain original fan control logic.\n- Updated E5M install/remove menus to check for a flag file for custom fan macros status.\n- Fixed helper.sh to source scripts from the E5M menu directory.
Removes the following items from the E5M-specific installation and removal menus: - Klipper Adaptive Meshing & Purging - Nozzle Cleaning Fan Control - M600 Support - Git Backup
Adds a placeholder "Nebula Camera Support" option to the E5M install and remove menus under the "CAMERA" section.\n\n- This new option is added as item 14 in both menus.\n- Subsequent menu items have been renumbered.\n- The install case calls `install_camera_settings_control` as a placeholder.\n- The remove case calls `remove_camera_settings_control` as a placeholder.\n- A placeholder variable `NEBULA_CAMERA_FILE` is used in the checks; this may need adjustment once the actual implementation details for Nebula camera are known.\n\nThis change prepares the E5M menus for specific Nebula camera integration. Further changes will be needed to implement the actual logic if it differs from standard camera settings control.
Removes the "Camera Settings Control" option from the E5M install and remove menus.\n\n- The "Nebula Camera Support" option (which previously called the same underlying camera settings functions) is now option 13.\n- "USB Camera Support" is now option 14.\n- Subsequent menu items have been renumbered accordingly.\n- Total menu items reduced from 21 to 20.\n\nThis change simplifies the camera options in the E5M menu. The "Nebula Camera Support" entry still uses placeholder calls to `install_camera_settings_control` and `remove_camera_settings_control`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current state - ready
git clone --branch ender5_max_support --single-branch https://github.com/supfeer/Creality-Helper-Script.git /usr/data/helper-script-e5msh /usr/data/helper-script-e5m/helper.shОбщие инструкции:
Убедитесь, что ваш принтер определяется как "E5M" (модель "F004") для всех тестов.
1. Тестирование специфичных функций E5M (основано на коммите
d908a16):Поддержка Зуммера (Buzzer Support)
$HS_CONFIG_FOLDER/buzzer-support.cfgсоздан как символическая ссылка наfiles/buzzer-support/buzzer-support-e5m.cfg.printer.cfgсодержит[include Helper-Script/buzzer-support.cfg].BEEP.printer.cfgудалены.Макросы Управления Вентиляторами (Fans Control Macros)
gcode_macro.cfgлибо не содержит секций[gcode_macro M106]/[gcode_macro M107], либо содержит стандартные.gcode_macro.cfgв$HS_BACKUP_FOLDER(например,gcode_macro.cfg.e5m_fans_backup_YYYYMMDDHHMMSS).[gcode_macro M106]и[gcode_macro M107]удалены из основногоgcode_macro.cfg.files/macros/fans-control-e5m-definitions.cfgдобавлено вgcode_macro.cfg.$HS_CONFIG_FOLDER/e5m_custom_fan_definitions_applied.flag.printer.cfgне включаетHelper-Script/fans-control.cfg.M106иM107.gcode_macro.cfgиз резервной копии (если существует).sed-командами.fans-control.cfg, включение вprinter.cfg, комментирование/раскомментирование конфликтующих секций).Регулировка Наклона Стола Винтами (Screws Tilt Adjust)
$HS_CONFIG_FOLDER/screws-tilt-adjust.cfgявляется символической ссылкой наfiles/screws-tilt-adjust/screws-tilt-adjust-e5m.cfg.screws-tilt-adjust-e5m.cfgна корректный порядок винтов: задний правый, задний левый, передний левый, передний правый.2. Тестирование структуры меню E5M (после коммитов
0d1a0ddи6d872bb, а также удалений пунктов меню):Меню Установки E5M (
scripts/menu/E5M/install_menu_E5M.sh):Klipper Adaptive Meshing & PurgingNozzle Cleaning Fan ControlM600 SupportGit BackupCamera Settings Controlinstall_camera_settings_controlили выдает ошибку при отсутствии зависимостей/наличии файла)Меню Удаления E5M (
scripts/menu/E5M/remove_menu_E5M.sh):remove_camera_settings_controlили выдавать ошибку, если не установлена.3. Тестирование функциональности "Save Z-Offset Macros" (запрос был, изменений в коде не было):
Testing Instructions for E5M
General Instructions:
Ensure your printer is identified as "E5M" (model "F004") for all tests.
1. Testing E5M Specific Functions (based on commit
d908a16):Buzzer Support
$HS_CONFIG_FOLDER/buzzer-support.cfgis created as a symbolic link tofiles/buzzer-support/buzzer-support-e5m.cfg.printer.cfgincludes[include Helper-Script/buzzer-support.cfg].BEEPG-code command.printer.cfgare removed.Fans Control Macros
gcode_macro.cfgeither has no[gcode_macro M106]/[gcode_macro M107]sections or has standard ones.gcode_macro.cfgis created in$HS_BACKUP_FOLDER(e.g.,gcode_macro.cfg.e5m_fans_backup_YYYYMMDDHHMMSS).[gcode_macro M106]and[gcode_macro M107]sections are removed from the maingcode_macro.cfg.files/macros/fans-control-e5m-definitions.cfgare appended togcode_macro.cfg.$HS_CONFIG_FOLDER/e5m_custom_fan_definitions_applied.flagis created.printer.cfgdoes not includeHelper-Script/fans-control.cfg.M106andM107G-code commands.gcode_macro.cfgfrom backup (if one exists).sedcommands.fans-control.cfg, inclusion inprinter.cfg, commenting/uncommenting conflicting sections).Screws Tilt Adjust
$HS_CONFIG_FOLDER/screws-tilt-adjust.cfgis a symbolic link tofiles/screws-tilt-adjust/screws-tilt-adjust-e5m.cfg.screws-tilt-adjust-e5m.cfgfor the correct screw order: rear right, rear left, front left, front right.2. Testing E5M Menu Structure (after commits
0d1a0ddand6d872bb, and menu item removals):E5M Install Menu (
scripts/menu/E5M/install_menu_E5M.sh):Klipper Adaptive Meshing & PurgingNozzle Cleaning Fan ControlM600 SupportGit BackupCamera Settings Controlinstall_camera_settings_controlor errors if dependencies are missing/file exists)E5M Remove Menu (
scripts/menu/E5M/remove_menu_E5M.sh):remove_camera_settings_controlor error if not installed.3. Testing "Save Z-Offset Macros" Functionality (request existed, no code changes):