-
Notifications
You must be signed in to change notification settings - Fork 0
Changed PR test comment #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,6 +37,8 @@ public class RegistrationController { | |
| @ApiResponse(responseCode = "201", description = "Returns the succesfull add response", content = @Content(mediaType = "application/json")) | ||
| @ApiResponse(responseCode = "409", description = "Returns the user already exists response", content = @Content(mediaType = "application/json")) | ||
| public HttpResponseDto register(@RequestBody SignUpDto userDto){ | ||
| System.out.println('test-pr') | ||
|
|
||
| return registerLoginServices.registerUser(userDto); | ||
| } | ||
| @Operation(description = "Logins the user with Http Basic Authentification", security = {@SecurityRequirement(name="Basic-Authentification")}) | ||
|
Comment on lines
38
to
44
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why did you do that @Gundwane21 |
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,4 +44,21 @@ public void getLeaderboardAllTimesTest() { | |
| List<Map<String, Long>> leaderboardAllTimes = leaderboardService.getLeaderboard(TimeInterval.ALL_TIMES); | ||
| Assert.assertEquals(result, leaderboardAllTimes); | ||
| } | ||
| @Test | ||
| @DisplayName("Test retrieving leaderboard for All Times2") | ||
| public void getLeaderboardAllTimesTest2() { | ||
| List<Map<String, Long>> result = new ArrayList<>(); | ||
| Map<String, Long> map = new HashMap<String, Long>(); | ||
| map.put("KeremTheMonopolyKing", (long) 100); | ||
| Map<String, Long> map2 = new HashMap<String, Long>(); | ||
| map2.put("GorkemOfRivia", (long) 180); | ||
| Map<String, Long> map3 = new HashMap<String, Long>(); | ||
| map2.put("John", (long) 360); | ||
| result.add(map); | ||
|
Comment on lines
45
to
+57
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test
Comment on lines
45
to
+57
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test |
||
| result.add(map2); | ||
| result.add(map3); | ||
| when(gameRecordStoreRepository.getLeaderboardAllTimes()).thenReturn(result); | ||
| List<Map<String, Long>> leaderboardAllTimes = leaderboardService.getLeaderboard(TimeInterval.ALL_TIMES); | ||
| Assert.assertEquals(result, leaderboardAllTimes); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comemnt