length 1 vector test for 'ALL' conditions#3
Open
hrbrmstr wants to merge 1 commit intoGunratan:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a tiny number of places where a parameter is tested to see if it equals
ALL.If one is running R with the following safety environment variables set:
_R_CHECK_LENGTH_1_CONDITION_=TRUE_R_CHECK_LENGTH_1_LOGIC2_=TRUEthey cause the functions with those test to fail. While it's easy to unset them, it is also straightforward to add a check, which is what this PR does.