ControllerTest RestDocsSupport를 상속받아 테스트를 수행하도록 리팩토링#132
Open
ControllerTest RestDocsSupport를 상속받아 테스트를 수행하도록 리팩토링#132
Conversation
onetuks
approved these changes
Jan 10, 2024
Contributor
onetuks
left a comment
onetuks
left a comment
There was a problem hiding this comment.
테스트 설정이 제일 어려운 것 같습니다.
고생하셨습니다 ㅠㅠ
Comment on lines
+33
to
+34
| academyCalendarService = mock(AcademyCalendarService.class); | ||
| academyCalendarFacade = mock(AcademyCalendarFacade.class); |
Contributor
There was a problem hiding this comment.
저희 Mock 제거하기로 해서, 이 코드는 없어질 것 같네요!
Comment on lines
+16
to
+18
| @ExtendWith(RestDocumentationExtension.class) | ||
| public abstract class RestDocsSupport { | ||
|
|
Contributor
There was a problem hiding this comment.
설정 클래스가 아닌 추상 클래스를 선택하신 이유가 궁금합니다!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
한 일
앞으로 해야할 일