Open
Conversation
1. The image series slider at the bottom no longer has a fixed minimum width. Previously, this could make the GUI take up more horizontal space than is available on a monitor, and would not allow you to resize. It is better if it just takes up the amount of available width, and allow the window to be resized, rather than forcing a minimum width. 2. The omage label now only takes up the maximum amount of space that it could take up for the particular imageseries that was loaded. Previously, it would take up potentially more space than would be needed. Now, we iterate through the possibilities and determine the max space. 3. Render flash in the raw view when changing image series frames is now fixed. It was only present for the raw view because the raw view is loaded synchronously in the main thread (as opposed to the other views which are loaded in a background thread). 4. Remove the `new_images_loaded` connection in the rotation series overlays and instead call the relevant function from the main window. Since the rotation series overlays are not QObjects, they would not disconnect properly when they were deleted. Iterating through them in the main window fixes this issue. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Collaborator
Author
|
@saransh13 I'm pretty sure this should fix #1990. Can you verify? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image series slider at the bottom no longer has a fixed minimum width. Previously, this could make the GUI take up more horizontal space than is available on a monitor, and would not allow you to resize. It is better if it just takes up the amount of available width, and allow the window to be resized, rather than forcing a minimum width.
The omage label now only takes up the maximum amount of space that it could take up for the particular imageseries that was loaded. Previously, it would take up potentially more space than would be needed. Now, we iterate through the possibilities and determine the max space.
Render flash in the raw view when changing image series frames is now fixed. It was only present for the raw view because the raw view is loaded synchronously in the main thread (as opposed to the other views which are loaded in a background thread).
Remove the
new_images_loadedconnection in the rotation series overlays and instead call the relevant function from the main window. Since the rotation series overlays are not QObjects, they would not disconnect properly when they were deleted. Iterating through them in the main window fixes this issue.Fixes: #1990