fix: display division directors and team leaders on review page#5737
Open
weimiao67 wants to merge 4 commits into
Open
fix: display division directors and team leaders on review page#5737weimiao67 wants to merge 4 commits into
weimiao67 wants to merge 4 commits into
Conversation
weimiao67
requested review from
Santi-3rd,
fpigeonjr,
johndeange,
josbell and
rajohnson90
as code owners
jonnalley
reviewed
May 29, 2026
|
|
||
| describe("agreement change accordion", () => { | ||
| it("check agreement meta-data", () => { | ||
| it.only("check agreement meta-data", () => { |
Contributor
There was a problem hiding this comment.
@weimiao67 did you intend to leave this change in place? The is effectively going to skip 12 tests that come after this.
Contributor
Author
There was a problem hiding this comment.
No, I forgot to remove it... fixed it in 9331690
josbell
approved these changes
May 29, 2026
josbell
reviewed
May 29, 2026
Contributor
josbell
left a comment
josbell
left a comment
There was a problem hiding this comment.
Approved assuming that the .only will be resolved
jonnalley
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixed the
AgreementMetaAccordioncomponent to display actual Division Director(s) and Team Leader(s) data from the agreement object instead of hardcoded "TBD" values. The component now renders names fromagreement.division_directorsandagreement.team_leadersstring arrays, with multi-column layout support when there are more than 3 entries.Issue
#5729
How to test
A11y impact
Screenshots
Definition of Done Checklist