Skip to content

fix: create example log directory correctly#242

Merged
LarFii merged 1 commit intoHKUDS:mainfrom
haosenwang1018:fix/create-example-log-dir-correctly
Apr 21, 2026
Merged

fix: create example log directory correctly#242
LarFii merged 1 commit intoHKUDS:mainfrom
haosenwang1018:fix/create-example-log-dir-correctly

Conversation

@haosenwang1018
Copy link
Copy Markdown
Contributor

Summary

  • create the actual example log directory instead of its parent in configure_logging()
  • add a focused regression test covering nested LOG_DIR values
  • keep the fix scoped to the current mainline example file that replaced the older OpenAI demo path

Testing

  • uv run python -m pytest tests/test_raganything_example.py -q
  • uv run ruff check examples/raganything_example.py tests/test_raganything_example.py
  • uv run ruff format --check examples/raganything_example.py tests/test_raganything_example.py
  • git diff --check

@LarFii
Copy link
Copy Markdown
Collaborator

LarFii commented Apr 21, 2026

Thanks for your contribution!

@LarFii LarFii merged commit 2002627 into HKUDS:main Apr 21, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants