fix: uniformly treat flow start time as a 64-bit unsigned integer#9
Open
matt-dbs wants to merge 1 commit into
Open
fix: uniformly treat flow start time as a 64-bit unsigned integer#9matt-dbs wants to merge 1 commit into
matt-dbs wants to merge 1 commit into
Conversation
Start times are being parsed in as `double`s, as if it is possible to specify fractional start times. For examples, 42.5ps. However internally they are stored into `connection.start`, a `simtime_picosec` (a.k.a. `uint64_t`). Apart from silently truncating fractional numbers this also leads to corrupted start times if a value greater than `UINT64_MAX` is specified. This change causes parsing to reject fractional or out-of-64-bit-range values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Like #8, this is another latent issue that bit us because we were writing our own connection matrices.
Start times are being parsed in as
doubles, as if it is possible to specify fractional start times. For examples, 42.5ps. However internally they are stored intoconnection.start, asimtime_picosec(a.k.a.uint64_t). Apart from silently truncating fractional numbers this also leads to corrupted start times if a value greater thanUINT64_MAXis specified.This change causes parsing to reject fractional or out-of-64-bit-range values.