feat: merge screenshot mode into make picture menu (#540)

[DhanashreePetare]

Description

Fixes #540

This PR merges “screenshot mode” and “make picture” into a single menu entry, reducing UI confusion. The screenshot mode toggle now lives inside the make‑picture menu, while still preserving fullscreen behavior and UI hiding during screenshot mode.

Changes

• Merged screenshot mode controls into the make‑picture menu.
• Removed the separate screenshot mode button from the UI menu and LHCb section.
• Preserved screenshot mode behavior (fullscreen + UI hidden via .ss-mode), now scoped to the make‑picture component.
• Added tests for screenshot mode toggle in the make‑picture component.

Behavior

• Click Make Picture → menu opens with options:
  • Enter/Exit screenshot mode
  • Set size/fitting and save picture
• Exiting fullscreen automatically leaves screenshot mode.

[sponce]

Thanks a lot for this new contribution @DhanashreePetare
Looks good to me and ready to merge. I only have 2 remarks/questions :

• the menu as it is does not really make obvious to me that : "Enter Screenshot mode" is a button you can click on and not a title. Do you see how to make this more obvious ? maybe adding a line around the button ? I see none in my configuration. Similarly for the "Create picture" button, but this is a bit less misleading as it's not at the top
• somehow the stretch version of create picture makes a crop for me. I believe it was already like this before this MR, but if you happen to know why, it would be great !

[DhanashreePetare]

Thanks for the review @sponce, I analyzed both the questions..and here is what I want to discuss.

1. You're right - the screenshot button should have similar visual distinction. We can add a border/styling to make "Enter/Exit screenshot mode" obviously clickable, matching the "Create picture" button style.

2. This is pre-existing behavior in the underlying makeScreenShot method (phoenix-event-display library), In Stretch mode, the code should not be cropping—it adjusts the camera's aspect ratio to fill the requested dimensions without losing content. However, if you're seeing a cropped appearance in Stretch mode, it might be a visual distortion from the perspective camera adjustment, not an actual crop. The default fitting is currently 'Crop' (line 18 in make-picture.component.ts), so Stretch should preserve the full view. Would you like me to investigate if there's a bug in the Stretch implementation, or else maybe open a new issue for the same?

[sponce]

Concerning 2, you're absolutely right. Strech works as expected. It's just that I had forgotten you previous fixes on it and I was expecting the ancient behavior. So forget my comment and thanks for the explanation.

Concerning 1, would be great indeed to change the button style.

[DhanashreePetare]

Have updated the styling @sponce. The screenshot mode button has the same visual treatment as the "Create picture" button now.

[sponce]

Thanks for the quick fix ! It's looking like a button now but... see the display on my screen :

Looks like there is too much margin on the side of the text.

[DhanashreePetare]

Sorry about the earlier update, my bad— I should have verified the button styling more carefully before pushing.
I’ve now fixed the screenshot-mode button styling, hope this is fine to go with:

still if there are any changes needed in this..please let me know. ThankYou