fix: replace deprecated substr() with substring() in URLOptionsManager#810
Open
GaneshPatil7517 wants to merge 1 commit intoHSF:mainfrom
Open
Conversation
…ger\n\nReplace window.location.href.substr() with substring() and add a guard\nfor missing query string to prevent incorrect behavior when the URL\nhas no '?' character."
GaneshPatil7517
force-pushed
the
fix/url-options-manager-replace-deprecated-substr
branch
from
cffba64 to
ddbd110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello @EdwardMoyse
What
Replaced the deprecated String.prototype.substr() call in url-options-manager.ts with String.prototype.substring(), along with a guard for URLs that don't contain a query string.
Why
substr() is deprecated in ECMAScript and behaves incorrectly when the URL has no ? character — lastIndexOf('?') returns -1, and substr(-1) extracts just the last character of the URL instead of returning an empty string. This leads to unexpected URLSearchParams being parsed.
How
Used indexOf('?') to find the query string position
Added a guard: if no ? is found, pass an empty string to URLSearchParams
Used substring() instead of substr() when the ? is present
Fixes #807