fix(renderer-manager): make swapRenderers() actually swap renderers (#808)#811
Open
GaneshPatil7517 wants to merge 1 commit intoHSF:mainfrom
Open
fix(renderer-manager): make swapRenderers() actually swap renderers (#808)#811GaneshPatil7517 wants to merge 1 commit intoHSF:mainfrom
GaneshPatil7517 wants to merge 1 commit intoHSF:mainfrom
Conversation
… params The swapRenderers method only swapped local parameter references, which had no effect on the caller or internal state. Replaced with logic that swaps entries in the renderers array and updates mainRenderer/overlayRenderer references accordingly. Fixes HSF#808
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello @EdwardMoyse
The
swapRenderersmethod only swapped local parameter references:Since JavaScript passes object references by value, reassigning the parameters inside the function has no effect on the caller or the class's internal state. The method silently did nothing.
Fix
Replaced the no-op local swap with logic that:
Tests
Added renderer-manager.test.ts with 5 test cases covering: