Move Methodology code block to Rainbow styles - #1594
Merged
Conversation
rviscomi
approved these changes
Nov 29, 2020
rviscomi
left a comment
rviscomi
left a comment
Member
There was a problem hiding this comment.
What's the process for generating Rainbow-specific markup? Should it be documented in a wiki?
Member
Author
Was the last process? 😉 Was thinking about writing a specific function for Methodology page, but after I discovered how easy it was I figured that was overkill. What about commenting the code like I just added in the last commit?: 3fc4d42 |
Member
|
SGTM. The wasn't a process last time, it was manual! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid duplication of code.
Follow on from #1574