v1.7.0 - Locked parameters and vectorization - #28
Merged
Conversation
…reviously. Vectorized exposure_time_calculator.py. Required parameters when regrid_wavelength is True. Removed minimum_IWA and maximum_OWA.
…ry. Vectorialized calc_exozodi_flux and calc_zodi_flux. Added parse_parameters at each load_configuration. Updated parsing of necessary variables. Refactored regrid_spectra function and interpolation functions. Regridded all relevant variables. Renamed parse_list_param to normalize_list_shapes. Added extra logs. Unit tested.
…te tutorial). Made the code fail if input is unclear with respect to lambda. npix_multiplier made scalar. Regridding ifs_eff (temporary). Added _parser flag for legacy users.
…up: Noticing disagreement in output between main spectroscopy_tutorial and branch spectroscopy_tutorial.
…us commit). Unit tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
[1.7.0] - 2026-07-13
Breaking Changes
ToyModelmode instead.parameters['overrides'] = [...]list (defaults toNone). The Imaging Tutorial has been updated accordingly to show an example.nchannelsdefault changed from 2 to 1: Previously, the code assumed simultaneous observation in 2 channels for all EAC modes, producing overly optimistic time estimates. This has now been changed to 1 and will be entirely removed in a future release.minimum_IWAandmaximum_OWAshortcut checks in exposure time calculations. These optimizations are no longer needed due to vectorization performance gains, and their removal eliminates a source of user confusion.Bug Fixes
mag,deltamag, andSNRnot being recalculated or regridded correctly whenregrid=True.physics_validationwhere detector values matching the original wavelength grid incorrectly failed validation.parse_input.Performance Improvements
calc_exozodi_fluxandcalc_zodi_flux.New Features / Improvements
LOCKED_KEYSfor consistent, config-driven component definitions in EAC/YIP mode (see Breaking Changes).parse_parameterscalls at every function that touches parameters, adopting a "better-safe-than-sorry" approach. Users no longer need to manually callparse_parameters. If they do, the_parserflag will protect the parameters dictionary from being parsed twice.regrid_spectraand related interpolation functions; all relevant variables are now properly regridded.parse_list_param→normalize_list_shapesfor clarity.npix_multiplieris now handled as a scalar internally.ifs_eff. This will change in the upcoming major release (see Looking Ahead).logger.debugmessages throughout to clarify which values are used and their source (default vs. user-provided).Testing & Documentation
Migration Notes
parameters['overrides']to specify which parameters to override. Default behavior (no overrides) is unaffected.nchannels=2behavior for EAC1: Exposure time results will change. Please re-validate any saved results generated with previous versions. Reproduce previous results by manually settingnchannels=2in input parameters.Looking Ahead
This release lays groundwork for upcoming changes, including proper spectral channel/filter treatment. Additional breaking changes are planned for a future major release (v2.0.0) — deprecation warnings will be added in upcoming minor releases to help users prepare in advance.