Skip to content

Dagim H.#5

Open
Unlock7 wants to merge 3 commits into
HackYourAssignment:mainfrom
Unlock7:main
Open

Dagim H.#5
Unlock7 wants to merge 3 commits into
HackYourAssignment:mainfrom
Unlock7:main

Conversation

@Unlock7

@Unlock7 Unlock7 commented May 28, 2026

Copy link
Copy Markdown

No description provided.

Comment thread API_DESIGN.md

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a space after the file name which can cause trouble. It also looks like the ending part of the file is missing, because I see only POST /api/analytics documented, and status codes are missing too.

@@ -1,4 +1,4 @@
package com.dagim.AnalyticsAPI;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package naming is inconsistent which causes that the project does not compile after checkout.

import org.springframework.boot.test.context.SpringBootTest;

@SpringBootTest
class AnalyticsApiApplicationTests {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is empty. At least all service methods in this application must have a unit test.

@Unlock7

Unlock7 commented Jun 10, 2026

Copy link
Copy Markdown
Author

Hi @composix,
Thank you for the thorough feedback.
I apologize for the delay in responding. I’ve reviewed all your comments and I fully understand the issues regarding the package naming inconsistency, the incomplete API_DESIGN.md, and the missing unit tests.
I’m working on correcting everything and ensuring the project compiles cleanly with proper documentation and tests.
I’ll submit the updated version shortly.
Thanks again for your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants