Salem B#6
Open
Barboud wants to merge 2 commits into
Open
Conversation
composix
suggested changes
Jun 9, 2026
| public AnalyticsRecord create(CreateAnalyticsRequest request) { | ||
| AnalyticsRecord record = new AnalyticsRecord(); | ||
|
|
||
| record.setTraceId(String.valueOf(counter)); |
There was a problem hiding this comment.
This is not thread-safe. Multiple simultaneous requests can result in records with the same traceId. It would also be better to used UUID for the unique ids instead of just numbers.
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| public class AnalyticsServiceTest { | ||
|
|
There was a problem hiding this comment.
This only tests the create method. A lot of methods are still untested. Test coverage should be improved.
| @@ -0,0 +1,8 @@ | |||
| package com.hyf.AnalyticsAPI.exception; | |||
|
|
|||
There was a problem hiding this comment.
For this exception to work an error handler is still needed. No I get 500 errors instead of 404 when items are not found.
| ## Delete Record | ||
|
|
||
| DELETE /analytics/{id} | ||
|
|
There was a problem hiding this comment.
Consider returning 204 here or return a body with some additional information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.