Yana P#1
Conversation
composix
left a comment
composix
left a comment
There was a problem hiding this comment.
Very solid implementation that feels production-ready. The coding patterns are consistent, and the code is kept simple and easy to read. I also like the minimal use of external libraries and the consistent use of Java records for DTOs.
Nice creative thinking as well: instead of trying to be a “database wizard”, the solution focuses on delivering a clear, maintainable, and reliable application.
| } | ||
|
|
||
| @Bean | ||
| public RestClient lyricsRestClient(RestClient.Builder builder){ |
There was a problem hiding this comment.
Nicely configured RestClient. Static request information, such as the base URL and default Accept header, is centralized in the configuration instead of being repeated across individual requests. This keeps the client code cleaner and easier to maintain.
There was a problem hiding this comment.
Nice idea to wrap the external REST API calls in a dedicated service. This keeps the integration logic isolated and makes the code easier to maintain and test.
| .retrieve() | ||
| .body(LyricApiResponse.class); | ||
| } catch(HttpClientErrorException.NotFound ex){ | ||
| return null; |
There was a problem hiding this comment.
Returning null here should be clearly documented, but using Optional would make the absence of a result more explicit and easier for callers to handle safely.
|
|
||
| if (apiResponse == null || apiResponse.lyrics() == null || apiResponse.lyrics().isBlank()){ | ||
| throw new LyricsNotFoundException(track.trackTitle(), track.artistName()); | ||
| } |
There was a problem hiding this comment.
If Optional were used in the LyricsClient, this code could be made more consistent with the findTrackWithArtist call. The caller could then use orElseThrow, making the “not found” flow more explicit and avoiding a separate null check.
There was a problem hiding this comment.
This is a useful startup check to verify that the application can connect to the database when it becomes ready. Consider using a logger instead of System.out.println, and make sure this class is registered as a Spring bean, for example with @Component.
There was a problem hiding this comment.
I like the initiative to not force everything into one large SQL query, even though the exercise mentions that as an option for SQL wizards. Splitting the logic into smaller SQL queries and Java methods can make the solution easier to read, understand, and debug.
2 participants
Completed Week 6 assignment: database connection, web fetching, and interface testing.
• 2 tests for user statistics (happy path + 404)
• 3 tests for track lyrics (happy path + missing track + missing lyrics)