-
Notifications
You must be signed in to change notification settings - Fork 7
Halyna R. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
halyna1995
wants to merge
1
commit into
HackYourAssignment:main
Choose a base branch
from
halyna1995:week-9-sql-assignment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Halyna R. #5
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,27 @@ | ||
| # Data Dictionary | ||
|
|
||
| Document both views. State the grain in one sentence, identify the keys, and list the measures (the columns you can aggregate). Replace every TODO. | ||
| This file documents the two analytical views created for the Week 9 NYC Taxi star schema. | ||
|
|
||
| ## vw_fact_trips | ||
|
|
||
| - **Grain:** TODO (one sentence, e.g. "One row per ...") | ||
| - **Primary key:** TODO | ||
| - **Foreign keys:** TODO | ||
| - **Measures:** TODO (columns you would SUM or AVG) | ||
| - **Grain:** One row represents one NYC green taxi trip from the raw trips table after removing rows where `fare_amount < 0`. | ||
| - **Primary key:** No explicit primary key is available in this view. The raw trips table does not provide a single unique trip identifier. `vendor_id` is not a primary key because the same vendor can appear in many trips. | ||
| - **Foreign keys:** | ||
| - `pickup_location_id` references `vw_dim_zones.location_id` | ||
| - `dropoff_location_id` references `vw_dim_zones.location_id` | ||
| - **Measures:** | ||
| - `passenger_count` | ||
| - `trip_distance` | ||
| - `fare_amount` | ||
| - `tip_amount` | ||
| - `total_amount` | ||
|
|
||
| ## vw_dim_zones | ||
|
|
||
| - **Grain:** TODO | ||
| - **Primary key:** TODO | ||
| - **Foreign keys:** TODO (or "none") | ||
| - **Measures:** TODO (or "none, descriptive attributes only") | ||
| - **Grain:** One row represents one NYC taxi zone. | ||
| - **Primary key:** `location_id` | ||
| - **Foreign keys:** None. | ||
| - **Measures:** None. This view contains descriptive attributes only: | ||
| - `location_id` | ||
| - `zone` | ||
| - `borough` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The join already make sure the left side is never null, so this statement doesn't hurt but is not strictly needed.