Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

The XML documentation for BuildSearchDirectories referenced a sibling check fallback that no longer exists. The AddSiblingEntityDirectories method was removed in commit 07ffa2f, but the documentation wasn't updated.

Changes:

  • Removed outdated reference to "The sibling check is kept as a fallback for non-nested structures"
  • Removed reference to removed entityNamespaces parameter in summary
  • Clarified that only context directory and parent directory are searched, with parent scan recursively including siblings
/// <remarks>
/// This method starts with the context directory and then its parent directory.
/// Since the parent directory scan is recursive, it will naturally include the context directory
/// and all siblings through the recursive search.
/// </remarks>

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ling check

Co-authored-by: HandyS11 <62420910+HandyS11@users.noreply.github.com>
Copilot AI changed the title [WIP] Apply feedback from review on code quality improvements Update BuildSearchDirectories documentation to reflect removal of sibling check Feb 3, 2026
Copilot AI requested a review from HandyS11 February 3, 2026 14:56
@HandyS11 HandyS11 marked this pull request as ready for review February 3, 2026 14:58
Copilot AI review requested due to automatic review settings February 3, 2026 14:58
@HandyS11 HandyS11 merged commit e72aea1 into refacto/ImproveCodeQuality Feb 3, 2026
2 checks passed
@HandyS11 HandyS11 deleted the copilot/sub-pr-12 branch February 3, 2026 14:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the XML documentation for the BuildSearchDirectories method to reflect the removal of the AddSiblingEntityDirectories method and associated sibling check logic. The documentation had become outdated after commit 07ffa2f removed the sibling check functionality.

Changes:

  • Removed outdated reference to "sibling check fallback" that no longer exists
  • Removed reference to non-existent entityNamespaces parameter in the summary
  • Clarified that the method searches the context directory and parent directory, with recursive parent scanning naturally including siblings
Comments suppressed due to low confidence (2)

src/ProjGraph.Lib/Services/EfAnalysis/EntityFileDiscovery.cs:205

            foreach (var csFile in Directory.EnumerateFiles(searchDir, EfAnalysisConstants.FilePatterns.CSharpFiles,
                         options))
            {
                var fullPath = Path.GetFullPath(csFile);
                if (fullPath.Equals(normalizedContextPath, StringComparison.OrdinalIgnoreCase))
                {
                    continue;
                }

                // Skip common non-source directories that can be large
                var pathSegments = fullPath.Split(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar);
                if (pathSegments.Any(s => s is "bin" or "obj" or ".git" or "node_modules"))
                {
                    continue;
                }

                await ProcessSourceFileAsync(fullPath, entityTypeNames, entityFiles);
            }

src/ProjGraph.Lib/Services/EfAnalysis/EntityFileDiscovery.cs:276

        foreach (var entityFile in entityFiles.Values.Distinct())
        {
            var entityCode = await File.ReadAllTextAsync(entityFile);
            var entityTree = CSharpSyntaxTree.ParseText(entityCode);
            var entityRoot = await entityTree.GetRootAsync();

            ExtractBaseClassNamesFromSyntax(entityRoot, baseClassNames);
        }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants