Skip to content

Disable Note Retention during parades - #396

Merged
JeodC merged 1 commit into
HarbourMasters:develop-splitrockfrom
JordanLongstaff:note-retention-fix
Aug 5, 2026
Merged

Disable Note Retention during parades#396
JeodC merged 1 commit into
HarbourMasters:develop-splitrockfrom
JordanLongstaff:note-retention-fix

Conversation

@JordanLongstaff

@JordanLongstaff JordanLongstaff commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #342

@JeodC

JeodC commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Note Retention wasn't really my domain. I saw you pinged me on that issue, and I did made two recent changes with #283 and #336. I believe they are related, but not altogether the solution as they hide the hud but you would still be granted an extra life. Then there's #293 which you linked in the issue, which was my attempt at ensuring retention stayed out of attract demos and bottles bonus (during trying to fix syncs, the thought was they might be affecting the demo's deterministic seed). If that was done incorrectly, then this is a good place to fix it.

I'll cc @Malkierian as they wrote the retention.

@Malkierian

Copy link
Copy Markdown
Contributor

I made some significant changes to how note retention works in a PR I'll be making soon. I don't think this will be an issue, but I'd like to have the parade tested with that PR before merging this in case I already incidentally fixed it with the other issues I fixed.

@Malkierian

Copy link
Copy Markdown
Contributor

@JordanLongstaff The other Anchor port is merged. Go ahead and test latest develop-splitrock to see if this is necessary. If it is, this will be the last PR before Charlie.

@JeodC

JeodC commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@JordanLongstaff The other Anchor port is merged. Go ahead and test latest develop-splitrock to see if this is necessary. If it is, this will be the last PR before Charlie.

It is.

@JeodC
JeodC merged commit f1dfd65 into HarbourMasters:develop-splitrock Aug 5, 2026
6 checks passed
@JordanLongstaff
JordanLongstaff deleted the note-retention-fix branch August 5, 2026 15:58
@JordanLongstaff

Copy link
Copy Markdown
Contributor Author

Thanks for doing that so I don't have to @JeodC 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants