Disable Note Retention during parades - #396
Conversation
|
Note Retention wasn't really my domain. I saw you pinged me on that issue, and I did made two recent changes with #283 and #336. I believe they are related, but not altogether the solution as they hide the hud but you would still be granted an extra life. Then there's #293 which you linked in the issue, which was my attempt at ensuring retention stayed out of attract demos and bottles bonus (during trying to fix syncs, the thought was they might be affecting the demo's deterministic seed). If that was done incorrectly, then this is a good place to fix it. I'll cc @Malkierian as they wrote the retention. |
|
I made some significant changes to how note retention works in a PR I'll be making soon. I don't think this will be an issue, but I'd like to have the parade tested with that PR before merging this in case I already incidentally fixed it with the other issues I fixed. |
|
@JordanLongstaff The other Anchor port is merged. Go ahead and test latest develop-splitrock to see if this is necessary. If it is, this will be the last PR before Charlie. |
It is. |
|
Thanks for doing that so I don't have to @JeodC 👍 |
Fixes #342