Skip to content

Build libultraship into the binary directory and the host asset packer optimized #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buddingmonkey wants to merge 2 commits into
base: develop-splitrock
Choose a base branch
from
Open

Build libultraship into the binary directory and the host asset packer optimized #418

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba5e097
Build libultraship into the binary directory and the host asset packe…
buddingmonkey Aug 6, 2026
dc9642d
Name libultraship's binary directory explicitly
buddingmonkey Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ if (CMAKE_GENERATOR MATCHES "Visual Studio")
)
endif()

add_subdirectory(libultraship ${CMAKE_CURRENT_SOURCE_DIR}/libultraship)
add_subdirectory(libultraship ${CMAKE_CURRENT_BINARY_DIR}/libultraship)
add_dependencies(${PROJECT_NAME} libultraship)
target_link_libraries(${PROJECT_NAME} PRIVATE libultraship)

Expand Down Expand Up @@ -743,7 +743,7 @@ include(ExternalProject)
ExternalProject_Add(TorchExternal
PREFIX TorchExternal
SOURCE_DIR ${CMAKE_SOURCE_DIR}/Torch
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${CMAKE_BINARY_DIR}/Torch -DENABLE_ASAN=${ENABLE_ASAN}
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${CMAKE_BINARY_DIR}/Torch -DENABLE_ASAN=${ENABLE_ASAN} -DCMAKE_BUILD_TYPE=Release
)
#set_target_properties(TorchExternal PROPERTIES EXCLUDE_FROM_DEFAULT_BUILD TRUE)
ExternalProject_Get_Property(TorchExternal install_dir)
Expand Down