Fix JP demo asset aliasing - #424
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The demo block occupies v1.0 asset ids 0x9A3..0xA0A, which alias to native ids 0x100 lower. The remap tables only carry the slots that hold payload, so for the gaps the symbol map kept the base ROM's own asset at that id (a different asset than v1.0's) and a decomp-hardcoded demo id loaded the wrong file. Alias the uncarried ids down 0x100, and erase + mark-empty the ones with
no native counterpart so they resolve silently.
Also add the missing
{ 2528, 2311 }and{ 2529, 2312 }entries to sV10toJPRemap. Both already existed in the v1.1 and PAL tables; JP was short.