Update .vscode and .devcontainer files#6246
Conversation
|
I believe we still had it based on 22 for a reason. |
|
If I use the container as defined in master, I'm unable to build the project. I assume ubuntu 22 ships a version of cmake that is too old. I can remove the changes to the container from this PR if you want to deal with that separately. |
|
There should be a way of updating the cmake version that gets installed in the docker, because our github workflows use 22 as well and don't have any issues with it. |
This commit makes some changes to the dockerfile to make it work again. We install cmake from source in order to meet the minimum required version specified in the CMakeLists.txt file. We build the same version that is installed on the CI runner image. We also build tinyxml2 from source because we need some cmake files that are apparently not included in the apt package.
|
I switched it back to ubuntu 22. I added some steps to build cmake from source so we can use the same version that's on the CI runners: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md |
|
Cool. I don't have any inherent problems with the current state of this now, but I have no way of testing anything in it. What uses tasks.json anyway? |
|
See also #6211
|
|
I merged the changes from #6211. The tasks work for me on linux, I can't test other platforms. |
Malkierian
left a comment
Malkierian
left a comment
There was a problem hiding this comment.
I would assume, since it's a VS Code thing, if they work on one platform, they'll work on any that you use VS Code on.
|
Whoops... wrong branch |
|
why LUS bump? |
|
I am extremely surprised the one just merged created no conflicts with this one. |
|
ugh #6211 was pointed at |
4 participants
This pr does two things:
Dockerfile. It now uses Ubuntu 24 LTS instead of 22, and installs all of the missing dependencies.tasks.jsonto include the Linux steps fromBUILDING.md. I kept the existing Windows steps, vscode will automatically select the commands appropriate for your os.The project builds just fine for me without the container, but the container is useful because I don't have easy access to
clang-format-14.Build Artifacts