Hard Code Small Key Doors#6578
Open
xxAtrain223 wants to merge 2 commits into
Open
Conversation
serprex
approved these changes
Apr 30, 2026
Contributor
|
before I start testing, does this account for #6575 yet or not? |
Contributor
Author
|
Yes, the 4 in water temple MQ was a 3 before your change.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Pepper0ni ***@***.***>
Sent: Thursday, April 30, 2026 6:47:44 AM
To: HarbourMasters/Shipwright ***@***.***>
Cc: xxAtrain223 ***@***.***>; Author ***@***.***>
Subject: Re: [HarbourMasters/Shipwright] Hard Code Small Key Doors (PR #6578)
[https://avatars.githubusercontent.com/u/93387759?s=20&v=4]Pepper0ni left a comment (HarbourMasters/Shipwright#6578)<#6578 (comment)>
before I start testing, does this account for #6575<#6575> yet or not?
—
Reply to this email directly, view it on GitHub<#6578 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABWNSRXSHPBJ4WGDS5YY2P34YM4OBAVCNFSM6AAAAACYLSYXPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGNJSGE4DCOJXG4>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Pepper0ni
reviewed
Apr 30, 2026
Pepper0ni
suggested changes
Apr 30, 2026
Contributor
Pepper0ni
left a comment
Pepper0ni
left a comment
There was a problem hiding this comment.
No other issues found, fix that 1 bug and I'll approve
Pepper0ni
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as we know, small key doors don't change between ROM versions, only between Vanilla and MQ. This PR removes the calculations and hard codes the small key doors to make it easier to change the swch flag used for the MQ Water Temple Small that was shared with Stalfos, fixed in #6575.
Build Artifacts