Fix Malformed Preset Filenames#6615
Open
unreference wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #6586.
Preset names are used directly as filenames without sanitization. Characters like
:are illegal in Windows filenames -- on NTFS,:creates an Alternate Data Stream instead of a regular file. A preset called "test :)" bricks the app. The save produces a malformed file,LoadPresetscallsnlohmann::json::parseon it with no error handling, and the resulting exception crashes the app on every subsequent launch.SanitizeFilenamefunction replaces< > : " / \ | ? *and control characters with_, stripping trailing dots and spaces. Applied in bothSavePresetandFormatPresetPath(used by delete). The preset's display name in JSON is unchanged -- the user still sees their original name in the UI.std::ofstreamdoesn't throw on failure -- it fails silently. Anis_open()check after opening lets the app log an error and returns instead of writing to a failed stream.nlohmann::json::parsein a try-catch so a malformed preset file logs an error and is skipped instead of crashing the app. This also serves to recover any existing installations stuck in a crash loop from previously created bad presets.