Skip to content

ROM Version Queries for Hardware Memory Extraction #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unreference wants to merge 6 commits into
base: develop
Choose a base branch
from
+46 −10
Open

ROM Version Queries for Hardware Memory Extraction #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
054d54c
feat(ZRom): Expose RomVersion as a member with public getter
unreference May 8, 2026
c0b34a6
feat(ZRom): IsPal and IsDebug ROM version queries
unreference May 10, 2026
7fa0fc1
feat(ZRom): IsN64 ROM platform query
unreference May 11, 2026
36540c6
fix(ZRom): Remove redundant IsN64
unreference May 11, 2026
eb43232
Revert "fix(ZRom): Remove redundant IsN64"
unreference May 11, 2026
3310bd2
fix(ZRom): Remove unused IsPal function
unreference May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion ZAPD/ZRom.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,41 @@ bool ZRom::IsMQ() {
}
}

bool ZRom::IsDebug() const
{
switch (BitConverter::ToInt32BE(romData, 0x10)) { // crc
case OOT_PAL_GC_DBG1:
case OOT_PAL_GC_DBG2:
case OOT_PAL_GC_MQ_DBG:
return true;
default:
return false;
}
}

bool ZRom::IsN64() const
{
switch (BitConverter::ToInt32BE(romData, 0x10)) { // crc
case OOT_NTSC_10:
case OOT_NTSC_11:
case OOT_NTSC_12:
case OOT_PAL_10:
case OOT_PAL_11:
case OOT_IQUE_TW:
case OOT_IQUE_CN:
return true;
default:
return false;
}
}

const RomVersion& ZRom::GetVersion() const
{
return version;
}

ZRom::ZRom(std::string romPath)
{
RomVersion version;
romData = DiskFile::ReadAllBytes(romPath);

BitConverter::RomToBigEndian(romData.data(), romData.size());
Expand Down
22 changes: 13 additions & 9 deletions ZAPD/ZRom.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,28 @@
#include <map>
#include <string>

struct RomVersion
{
std::string version = "None";
std::string error = "None";
std::string listPath = "None";
int offset;
uint32_t crc;
};

class ZRom
{
public:
ZRom(std::string romPath);

std::vector<uint8_t> GetFile(std::string fileName);
bool IsMQ();
bool IsDebug() const;
bool IsN64() const;
[[nodiscard]] const RomVersion& GetVersion() const;

protected:
std::vector<uint8_t> romData;
std::map<std::string, std::vector<uint8_t>> files;
};

struct RomVersion
{
std::string version = "None";
std::string error = "None";
std::string listPath = "None";
int offset;
uint32_t crc;
RomVersion version;
};