Add Cloud Identity display_name policy#292
Conversation
Shani1116
left a comment
There was a problem hiding this comment.
Documentation - resource_json file is missing
Only one policy is available and it does not follow the PDE policy format.
Please revise and update.
| @@ -1,3 +1,9 @@ | |||
| --- | |||
There was a problem hiding this comment.
Remove unrelated comments.
There was a problem hiding this comment.
okay unrelated comments removed successfully
|
Hi @Shani1116 , I've updated the Cloud Identity policy to follow the PDE format, added the missing resource_json documentation, and removed the unrelated comment noise from the docs changes. The branch has been updated and the policy check is passing. Please take another look when you have a chance. |
Shani1116
left a comment
There was a problem hiding this comment.
Not a completed PR. Please close this if you are not done with writing all policies.
If you need feedback from seniors, please share your branch name in the students chat without raising a PR.
|
Hi @Shani1116 , I've finished the Cloud Identity display_name policy! Here's what I did: ✅ Created the policy using the PDE format with conditions array and message rules The policy now correctly validates that Cloud Identity Groups have the required display_name attribute and generates proper violation messages. Ready for your review whenever you get a chance. Thanks! |
|
Still not following the correct policy format. Please reach out to a senior or rewatch the upskilling - policy writing videos and resubmit with the correct format. |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
b95b343 to
a429a49
Compare
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
🔍 Documentation Check FailedStatus: ❌ CHECKS FAILED ❌ No documentation changes found - please update docs for your assigned service Please add or update documentation in the |
🔍 Documentation Check FailedStatus: ❌ CHECKS FAILED ❌ No documentation changes found - please update docs for your assigned service Please add or update documentation in the |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
94b3fa4 to
66218d2
Compare
🔍 Policy Check ResultsStatus: ❌ CHECKS FAILED Test Output |
66218d2 to
10e8e98
Compare
🔍 Policy Check ResultsStatus: ❌ CHECKS FAILED Test Output |
10e8e98 to
8f27dfe
Compare
🔍 Policy Check ResultsStatus: ❌ CHECKS FAILED Test Output |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
Update: Cloud Identity Policy Work CompletedAll requested Cloud Identity updates are now completed, and the PR checks are passing. What was implemented
CI/Validation notes
✅ Current status: PR checks are passing and ready for review/merge. |
🔍 File Validation FailedStatus: ❌ VALIDATION FAILED ❌ Service PRs can only modify files in: inputs/gcp/, policies/gcp/, and docs/gcp/
Service PRs can only modify files in:
|
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
44f9f71 to
315bb6a
Compare
🔍 Policy Check ResultsStatus: ✅ All checks passed Test Output |
Added PDE policy for GCP Cloud Identity group display_name validation.
Changes: