ci: bump ai-review-prompts pin to f22bf7d (post #37 + #38 + #40) + label-gated review#152
Open
heskew wants to merge 1 commit into
Open
ci: bump ai-review-prompts pin to f22bf7d (post #37 + #38 + #40) + label-gated review#152heskew wants to merge 1 commit into
heskew wants to merge 1 commit into
Conversation
dawsontoth
approved these changes
May 18, 2026
heskew
force-pushed
the
ci/bump-ai-review-prompts-20c2157
branch
from
28e6a06 to
d2fcd0d
Compare
heskew
changed the title
heskew
force-pushed
the
ci/bump-ai-review-prompts-20c2157
branch
from
d2fcd0d to
dc998b4
Compare
heskew
changed the title
…bel-gated review Three changes from ai-review-prompts main since this PR was first opened: - #37: harper/common.md gains "Meta-checks" section + reuse / CI hygiene / lockfile drift bullets. - #38: label-gated review for bot-authored PRs (`claude-review` label as opt-in gesture). - #40: revert of #39's workflow-level `permissions: {}` on reusables — #39 broke reusable callers via the calling- workflow-caps-reusable rule. Empirically verified working on harper main (PR #576). Caller changes in this commit: - Pin bumped to `f22bf7d` (post-#37 + post-#38 + post-#40). Catches the pin up from `3278ce4e` (post-#20) which main was rolled back to during the #39 incident. - `pull_request: types:` adds `labeled` so the new bot-PR gesture fires. - **No caller-side `permissions: {}`**. Earlier version included that recommendation from #39; #40 reverted the recommendation. Repo-side prerequisite (already applied via `gh label create`): - `claude-review` label exists on this repo. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
heskew
force-pushed
the
ci/bump-ai-review-prompts-20c2157
branch
from
dc998b4 to
f1e7a3d
Compare
heskew
changed the title
kriszyp
approved these changes
May 19, 2026
cb1kenobi
approved these changes
May 21, 2026
Member
|
I am skeptical we want humans reviewing this, it looks like it is mostly numbers? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up three ai-review-prompts changes from main:
harper/common.mdcalibration update — new "Meta-checks (run these before tracing internals)" section (test validity / right target / premise) plus existing-dep reuse, CI workflow hygiene, and lockfile drift bullets.claude-reviewlabel on a renovate / dependabot PR, and thelabeledevent admits the run with the labeler instead of the bot PR author.permissions: {}on reusables. Update integration tests to use new apis #39 broke reusable callers via the GH Actions calling-workflow-caps-reusable rule. Empirically verified working — harper main (PR #576) with the same shape produced a successful label-gated review on a renovate PR.Caller changes
f22bf7dcb7d22d5de94c938daa9d790f2b5c776b.pull_request: types:addslabeledso the bot-PR gesture fires.permissions: {}— earlier version of this PR included that recommendation from Update integration tests to use new apis #39; fix: Always latest #40 reverted it.Prerequisite (already applied via
gh label create)claude-reviewlabel exists on this repo.Test plan
claude-reviewlabel fires the review workflow with the labeler-as-trust auth pathif:filter)🤖 Generated with Claude Code