Skip to content

Update package-lock.json #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kriszyp wants to merge 7 commits into
base: main
Choose a base branch
from
+37 −52
Open

Update package-lock.json #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
299357d
Update package-lock.json
kriszyp May 14, 2026
418bce2
fix: add missing optional native deps to package-lock.json
kriszyp May 14, 2026
87d75eb
remove bufferutil and utf-8-validate from optionalDependencies
kriszyp May 14, 2026
211bdaf
fix(ci): use npm ci --omit=optional in lint workflow
kriszyp May 14, 2026
47c68b0
fix(ci): omit peer deps in lint workflow npm ci
kriszyp May 14, 2026
cfa3255
fix(ci): use npm install --ignore-scripts for lint workflow
kriszyp May 14, 2026
5d83482
Merge remote-tracking branch 'origin/main' into update-package-lock
kriszyp May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-code.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ jobs:
with:
node-version-file: '.node-version'
cache: 'npm'
- run: npm ci
- run: npm install --ignore-scripts
Copy link
Copy Markdown
Member

@cb1kenobi cb1kenobi May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not going to honor the lock file. Can we do this?

Suggested change
- run: npm install --ignore-scripts
- run: npm ci --ignore-scripts

Copy link
Copy Markdown
Member Author

@kriszyp kriszyp May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work, it is not possible to create a lock file with our set of transitive dependencies derived from the ws dependency and the native dependencies that will satisfy npm ci.

Copy link
Copy Markdown
Member Author

@kriszyp kriszyp May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But npm ci seems to be passing on main now. Pure black magic, I don't understand. (not gonna merge unless we need this)

- run: npm run lint:required
83 changes: 35 additions & 48 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,6 @@
}
},
"optionalDependencies": {
"bufferutil": "^4.0.9",
"segfault-handler": "^1.3.0",
"utf-8-validate": "^5.0.10"
"segfault-handler": "^1.3.0"
}
}
Loading