test(integration): computed indexed properties (port legacy 18)#730
Merged
Conversation
Self-contained suite that installs the `computed` component, exercises @computed(from:"...") expressions and JS-callback computed attributes via REST PUT, search_by_value, and REST query-string filter paths. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Reviewed; no blockers found. |
Caught by Gemini review: jsTotalPrice was requested in get_attributes but not asserted, leaving JS-callback computed fields unverified via the Operations API. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
search_by_value returns the stored indexed value, which is null when the record is PUT before resources.js finishes loading (setComputedAttribute is a runtime registration, not embedded in the schema). The legacy test correctly omitted this assertion. jsTotalPrice is covered by the REST GET with ?select test, which evaluates it on-demand. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
Unit Test (Node.js v24) failed on — Claude |
cb1kenobi
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apiTests/tests/18_computedIndexedProperties.mjsto the new self-contained frameworkcomputedcomponent inline withinstallAppComponent, defining aProducttable that has@computed(from: "...")expression fields and a JS-callback field viasetComputedAttributesearch_by_value(with and withoutget_attributes), REST GET by id (with and withoutselect), and REST query-string filters on both indexed computed attributesdelete,drop_table,drop_componentTest plan
restart_service http_workers)🤖 Generated with Claude Code
— Claude