Expose ensureTable on plugin scope#743
Open
Baijack-star wants to merge 1 commit into
Open
Conversation
kriszyp
approved these changes
May 22, 2026
cb1kenobi
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scope.ensureTable(options)for the newhandleApplication(scope)plugin APIensureTablebehavior of stamping the componentoriginbefore delegating totable(options)originintoScopeand cover it with a component-loader unit testWhy
Issue #607 notes that plugins migrating from the old
start/startOnMainThreadAPI lose access to the legacyensureTablehelper. The old helper did:This keeps that same behavior available from
handleApplication(scope)asscope.ensureTable(options).Verification
npm_config_cache=/tmp/npm-cache-harper-ensuretable npm ci --ignore-scriptsnpm run buildnode --expose-internals --enable-source-maps --experimental-vm-modules - <<'NODE' ... NODErunningunitTests/components/componentLoader.test.jswith grep/ensureTable/afterinitTestEnvironment()npm run lint:required -- components/Scope.ts components/componentLoader.ts unitTests/components/componentLoader.test.jsgit diff --checkNote: running
./node_modules/.bin/mocha unitTests/components/componentLoader.test.js --grep ensureTabledirectly failed before the test loaded because the component loader imports modules that expect the unit-test environment to be initialized. The programmatic Mocha run initializesenvironmentManager.initTestEnvironment()first and the new test passes.I used an AI coding assistant to prepare this patch.
Fixes #607