test(integration): component lifecycle tests (port legacy 15)#759
Open
kriszyp wants to merge 2 commits into
Open
test(integration): component lifecycle tests (port legacy 15)#759kriszyp wants to merge 2 commits into
kriszyp wants to merge 2 commits into
Conversation
Port 15_customFunctionsAndComponents.mjs to the self-contained integration-test framework. Covers deploy_component (GitHub, tar, tar.gz payloads), set/get_component_file, add/package/drop_component, and the full custom-functions API (add, set, get, drop, deploy_custom_function_project). Skipped on Windows (restart_service crash) and Bun (restart reliability). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Assert deploy_component GitHub response on both success and retry paths - Use local fixture file for add_component unconditionally (avoids npm registry dependency) - Relax get_custom_functions assertion after drop to not deepEqual full state (fragile when GitHub deploy is flaky) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Reviewed; no blockers found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports
apiTests/tests/15_customFunctionsAndComponents.mjsto the self-contained integration-test framework.Covers:
deploy_componentvia GitHub package (with retry logic), inline tar payload, and inline tar.gz payload (withrestart: true)set_component_file/get_component_fileadd_component(using local fixture) /package_component/get_components/drop_componentadd_custom_function_project,custom_functions_status,set/get/drop_custom_function,get_custom_functions,drop_custom_function_projectdeploy_custom_function_projectwith an inline payloadSkipped on Windows and Bun due to
restart: truecrashing the single-worker model (#549).Design decisions
add_componentnow uses the localfixtures/application-template-1.0.0.tgzunconditionally rather than only on Windows — this avoids a live npm-registry network call on Linux/macOS CI.get_custom_functions after project dropassertion was relaxed from adeepEqualof the full response (fragile if GitHub deploy is flaky) to just checking the dropped project key is absent.Known limitations (from Gemini review — suggestions, not blockers)
deploy_component using tar.gz payloadtest strictly requires a restart. A finer-grained skip would allow the other tests to run on those platforms. Left as a follow-up.Generated by Claude Sonnet 4.6