test(integration): port delete operations tests to self-contained framework#761
Draft
kriszyp wants to merge 2 commits into
Draft
test(integration): port delete operations tests to self-contained framework#761kriszyp wants to merge 2 commits into
kriszyp wants to merge 2 commits into
Conversation
…mework Ports 8_deleteTests.mjs (76 tests) to the new per-suite isolated Harper instance pattern. Creates its own northnwd.employees and dev.rando fixtures in before(); uses awaitJob/getJobId from utils/operations.mjs for async job polling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add create_schema/create_table for numeric-string schemas '123'/'1123' and their tables in before() — these were created by 1_environmentSetup.mjs in the legacy shared suite but missing from the self-contained port - Fix search_by_hash in 'Verify object and array records deleted': last hash_value was duplicated 7925 instead of 7927 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Reviewed; no blockers found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8_deleteTests.mjs(76 tests) to the new per-suite isolated Harper instance pattern inintegrationTests/apiTests/delete.test.mjsstartHarper/teardownHarperbefore()creates all required fixtures:northnwd.employees,dev.rando(4 pre-seeded records), and numeric-string schemas123.4/1123.1that the legacy suite inherited from1_environmentSetup.mjsawaitJob/getJobIdfromutils/operations.mjsfor async job pollingAttention areas
delete_files_beforetests depend on ainsertTimestampvariable captured between two insert batches — this replaces the legacytestData.insert_timestampmutable shared state. The timing is tight: we capture the ISO timestamp immediately before the second batch, which should be sufficient but is worth verifying on slow CI runners.setTimeoutdelays from the legacy file are preserved (27s total). These were in the original for disk-async reasons; I left them rather than risk flakiness, but they could be reduced in a follow-up if CI confirms they're unnecessary.🤖 Generated by Claude Sonnet 4.6