Skip to content

Bump both reviewer pins to ai-review-prompts@ea19009#88

Merged
heskew merged 2 commits into
mainfrom
gemini/bump-to-promoted
May 21, 2026
Merged

Bump both reviewer pins to ai-review-prompts@ea19009#88
heskew merged 2 commits into
mainfrom
gemini/bump-to-promoted

Conversation

@heskew
Copy link
Copy Markdown
Member

@heskew heskew commented May 21, 2026

Summary

Adopts the promoted Gemini calibration (ai-review-prompts#41) and restores both reviewers to a single shared pin (ea190091328bcee674c4739ccc97dda177ecf0c5).

Gemini changes vs the prior pin (128656e40)

  • Single-shot architecture validated empirically over 5 iteration rounds in Inline Gemini reviewer for calibration #87 (gemini/inline-calibrate). The ai-review-prompts main branch had drifted onto an MCP-based rewrite that nothing in production was using; fix: default redirectUri matches Harper dev config (http://localhost:9926) #41 replaces it with the calibrated single-shot.
  • Prior-review body injection for continuity — the workflow now fetches the prior comment body when one exists and the prior had ### N.-shaped findings, and injects it into the prompt as a "Continuity reference" section. Skipped on no-blockers priors so the model isn't primed to hunt for issues against uninformative context.
  • Prompt's "your output IS the PR comment" section reworded to allow shell/file research tools (gemini-cli has them by default and the model does use them to research the diff) while still forbidding self-posting (the workflow handles posting). Resolves a latent self-contradicting prompt that surfaced as a finding once the calibration loop got fast enough to see it.
  • post-review-comment.sh marker check now strips leading whitespace from the first non-blank line so a non-whitespace-stable provider can't break the marker check.

Claude lockstep restored

_claude-review.yml is byte-identical between f22bf7d and ea19009 in ai-review-prompts (the divergence period only touched Gemini files). Bumping Claude's pin in lockstep is a no-op for Claude behavior but restores both reviewers to a single shared upgrade motion — the "intentionally NOT in lockstep" comment from the divergence period is replaced with a note that lockstep is restored.

Follow-ups

Test plan

  • Both claude-review and gemini-review workflows fire on this PR
  • Claude posts a "Reviewed; no blockers found" (or reasonable equivalent) — the change is pin bumps only, no logic changes
  • Gemini posts a "Reviewed; no blockers found" (or reasonable equivalent) — same
  • Both review-log entries thread correctly (per-PR, per-provider issues with the right markers)

🤖 Generated with Claude Code

Adopts the promoted Gemini calibration (ai-review-prompts#41) and
restores both reviewers to a single shared pin.

Gemini changes vs the prior pin (128656e40):
- Single-shot architecture validated empirically over 5 iteration
  rounds in PR #87 (gemini/inline-calibrate)
- Prior-review body fetched and injected as continuity context when
  the prior had findings (### N. headers); skipped on no-blockers
  priors so the model doesn't get primed to hunt for issues against
  uninformative context
- Prompt's "your output IS the PR comment" section reworded to
  allow shell/file research tools while still forbidding self-
  posting (the workflow handles posting)
- post-review-comment.sh now strips leading whitespace from the
  marker line so a non-whitespace-stable provider can't break the
  marker check

Claude reviewer is byte-identical between f22bf7d and ea19009 in
ai-review-prompts; bumping the pin is a no-op for Claude behavior
but restores the two reviewers to a single shared upgrade motion.
The "intentionally NOT in lockstep" comment from the divergence
period is replaced with a note that lockstep is restored.

PR #87 (gemini/inline-calibrate) is now superseded by this PR and
will be closed without merging.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@heskew heskew requested a review from a team as a code owner May 21, 2026 00:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

Reviewed; no blockers found.

Mirrors the hardening on claude-review.yml — explicit grant at the
calling-job level for the union the reusable's authorize + review
jobs need (contents: read + pull-requests: write + id-token: write).
The workflow happens to work without this on oauth today because
the repo default is permissive enough, but the explicit grant
survives repo-default changes and matches claude-review.yml's
shape and discipline.

Surfaced as a finding by Gemini's own review of this PR (#88) —
exactly the loop the calibration was built for.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@heskew heskew merged commit 3ff922c into main May 21, 2026
9 of 10 checks passed
@heskew heskew deleted the gemini/bump-to-promoted branch May 21, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant