Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughInference now supports resuming interrupted runs by validating existing ChangesResumable inference
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant Dataset
participant PredictionFiles
participant DataLoader
CLI->>Dataset: compute pending indices
Dataset->>PredictionFiles: validate existing predictions
PredictionFiles-->>CLI: return pending indices
CLI->>DataLoader: create Subset from pending indices
DataLoader-->>CLI: provide remaining samples
CLI->>PredictionFiles: atomically save predictions
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@infer.py`:
- Around line 83-88: The save_prediction_atomic function must avoid reusing the
fixed “.tmp” pathname across concurrent saves. Create a unique temporary file in
the destination directory for each save, write the NPY data to it, then
atomically replace save_to and clean up any temporary file if the operation
fails.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Contributor
|
Note Docstrings generation - SUCCESS |
Docstrings generation was requested by @Haruko386. * #32 (comment) The following files were modified: * `infer.py`
Removed commented-out code for UNet2DConditionModel instantiation.
📝 Add docstrings to `moonshot`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
support resume infer dataset from the lastest(only infer)
Related Issue
Related to #16
Type of Change
Test Results
Waitting for test on server
Summary by CodeRabbit