Draft
Conversation
Co-authored-by: Havret <9103861+Havret@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add full support for JsonNumberHandling
Implement full JsonNumberHandling support
Nov 9, 2025
Owner
|
@copilot Is it possible to reimplement this by using JsonTypeInfo? |
Contributor
Author
The JsonTypeInfo approach would require significant changes and has compatibility trade-offs: Current Implementation:
JsonTypeInfo Approach:
Since the library targets netstandard2.0 for broader compatibility, the current converter-based approach is more appropriate. If you'd like to move to JsonTypeInfo, we'd need to either drop netstandard support or maintain two separate implementations with conditional compilation. Would you like me to create a JsonTypeInfo-based implementation with conditional compilation to maintain backward compatibility? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously only
AllowReadingFromStringwas partially supported. This adds complete support for allJsonNumberHandlingflags per the Microsoft documentation.Changes
FieldConverter.cs
WriteAsStringsupport: numbers serialize as JSON strings when flag is setAllowNamedFloatingPointLiteralssupport: handles "NaN", "Infinity", "-Infinity" for float/double typesJsonExceptionwhen named literals are used without the flagJsonNumberHandlingTests.cs
Example Usage
All numeric types (int32, int64, float, double, etc.) are supported. Named literals only apply to float/double as per spec.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.