Ensure AtomicWriter defaults to '.' for current directory files#37
Ensure AtomicWriter defaults to '.' for current directory files#37HeadyConnection wants to merge 1 commit intomainfrom
Conversation
The AtomicWriter class now correctly defaults the directory to '.' when os.path.dirname returns an empty string (e.g., for files in the current directory). This prevents potential cross-device link errors when moving the temporary file to the destination. Modified the comment in `write_json` to reflect that this is the permanent behavior, removing the 'FIX:' marker. Co-authored-by: HeadyConnection <250789142+HeadyConnection@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Updated
AtomicWriter.write_jsonincodex_builder_v13.pyto ensure that ifos.path.dirname(path)returns an empty string (which happens for files in the current directory), the directory is explicitly set to.instead of being empty. This ensures thattempfile.NamedTemporaryFilecreates the temporary file in the same directory as the target file, which is required foros.replaceto work atomically without cross-device link errors. Verified the fix with a temporary test script.PR created automatically by Jules for task 9731532698555564618 started by @HeadyConnection