Feature/test scripts coverage#136
Open
peasandwell wants to merge 2 commits into
Open
Conversation
Closed
| "stylelint-config-recommended": "^2.1.0" | ||
| }, | ||
| "jest": { | ||
| "collectCoverageFrom": [ |
There was a problem hiding this comment.
Could this be inverted so for now it only calculates coverage in the directory we've tested?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds config files for running
npm run test-watch -- --coverageto get a Jest coverage of unit testing. Now it shows where there are gaps for us to fill in with proper unit testing.I've omitted several files from the coverage tool, including individual components as we feel that they are not suitable for test scripts at this time. However if we change our minds in the future we can happily do so.
Issues fixed
This addresses #83 as much as I can do for the time being. I think anything else requires someone that 100% understands the actions/reducers/APIs.
Checklist
npm testreturns no warnings or errors.