Feat/genf 67 spacing #2828
Merged
Feat/genf 67 spacing #2828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparation to try to simplify the spacings in the code to hopefully be provided by the parent layout rather than have the child components know about where they are supposed to be placed
Keep step content in /ui/step and keep the components only used in one place private to those files. Keep components that are shared across steps in /ui/common
We will not be using this in the foreseeable future so it's simpler to comment it out for now
Makes it easier to reason about spacings around conditional composables
* Remove redundant `Column` wrappers in `FormStep` and `FreeTextInputSection`. * Wrap action buttons in `Column` with `Arrangement.spacedBy` for consistent spacing in `FormStep`, `UploadFilesStep`, and `AudioRecordingStepSections`. * Replace `Column` with `Box` in `UploadFilesStep` and `ChatClaimSummaryStep` for simpler layout. * Add horizontal padding to content within the summary card instead of the root `Column`. * Use `contentPadding` for `LazyRow` in `ChatClaimSummaryStep`. to make images go "edge-to-edge"
# Conflicts: # app/feature/feature-claim-chat/src/commonMain/kotlin/com/hedvig/feature/claim/chat/ui/step/audiorecording/AudioRecordingStepSections.kt
panasetskaya
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make working with spacings easier, this PR mostly contains code changes of me moving all of the step components into their own files.
And keeping some shared components in the /common directory.
This removes all paddings that are added internally in step contents that lived at the top or the bottom of the component, so the parent can decide on how those components should be laid out in relation to one another.
This also allow all the file-showing LazyRows to go "edge-to-edge" by extending the horizontal space they take up by as much as the contentPadding is one the outer LazyColumn