Conversation
|
"This is not how I wanted to do this" is referring to the package split...? I'm sorry this caused such a hassle; but hopefully smoother moving forward... and yes, the PR certainly has interesting ideas that I will incorporate either here or the main pkg. Thank you, always, for any contribution really... |
|
'not how i planned" was referring to the fact that i PRd directly on your repo instead of driving from my fork. |
|
I see how to make the checks pass, will do ASAP. |
|
Fyi that I'll try to pull this locally, resolve, pass checks, and merge; ok? |
|
I don't think this vignette adds much. I think with better doc we can just avoid the tasks in this vignette |
|
Agree re vignette. Tho using geom_sf and adding point subsets look useful. Will ponder on how to incorporate these ideas. Currently shape rendering is a bit hacky and one would have to create a point subset in the object = not so good. |
This is not how I wanted to do this but anyway. I don't know if these functions are actually contributing
anything new. I need to spend more time with what you already have. Feel free to close this if it
looks redundant.